exposedev / exposedev/expose

[Bug]: Vite path doesn't revert properly after ending share

Open
#448 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
4.6k
Forks
308
PR merge metrics
No merged PRs in 30d

Description

### System architecture

Mac, Apple Silicon

### PHP Version

PHP 8.4.4

### Bug description

Basically, while sharing a site that's running vite (e.g. `pnpm run dev`) and you end the share, the vite client path doesn't revert to the original path, breaking vite entirely for that site until you restart vite. I'm using `herd share` but I think this would happen with `expose share` as well.

### Steps to reproduce

1. Run `pnpm run dev` or similar to start Vite server. (vite url at this point is `https://sitename.test:5173/@vite/client`
2. Run `herd share` or `expose share` (vite url gets changed to `https://expose-url.expose-domain.com/@vite/client`)
3. End share via `CTRL-C` (vite url gets changed to `/@vite/client` which is incorrect and does not work)
4. Vite is now broken.

### Relevant log output

```shell
N/A
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.