expo / expo/expo-github-action
continuous-deploy-fingerprint: eas 22 github commenting is broken
- Dominant language
- TypeScript
- Stars
- 1k
- Forks
- 107
- PR merge metrics
- No merged PRs in 30d
Description
### Description of the bug
How would you shortly summarise the issue?
The build completes and succeeds on the expo dashboard but the github comment doesn't come through and the github action for the deploy fails.
### To Reproduce
What steps did you perform which led to this issue?
Use continuous-deploy-fingerprint normally with eas-version: latest
#### Expected behavior
What did you expect to have happened?
It doesn't error when sending the github comment
#### Actual behavior
What did it actually result in?
It errors when sending the github comment with
`Cannot read properties of undefined (reading 'ownerAccount')`
### Additional context
Can you further explain the issue? E.g., information about version/environment or screenshots.
eas-cli 22 renamed build JSON fields: project → app, channel → updateChannel, runtimeVersion → runtime. The fingerprint action still does this when posting the PR comment:
```ts
export function getBuildLogsUrl(build: BuildInfo): string {
const { project } = build;
const path = `/accounts/${project.ownerAccount.name}/projects/${project.slug}/builds/${build.id}`;
```
build.project is now undefined, so you get Cannot read properties of undefined (reading 'ownerAccount'). That matches the log: matching builds are found, “Publishing EAS Update...” runs for ~2 minutes (the update itself likely succeeded), then the action dies on the comment.
Contributor guide
Research direction
Start at getBuildLogsUrl(build) in the comment-publishing path and inspect the BuildInfo shape returned by eas-cli 22. Compare the renamed build fields in the issue with the values used to construct the URL, then run the action's existing tests or a deploy reproduction. Done means a successful EAS build posts the GitHub comment without the ownerAccount error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions, typescript
- Domain
- ci-cd
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 72/100