expo / expo/expo-github-action

Beta Updates Github hook on expo.dev doesn't trigger in monorepo when pushing multiple commits to branch

Open
#314 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1k
Forks
107
PR merge metrics
No merged PRs in 30d

Description

Not sure if this is the right repo to open this issue.

### Description of the bug
When using the beta github hook for eas updates in a monorepo, if I push multiple commits at once to a branch and the last doesn't change files inside the expo app folder, the hook does not trigger.

### To Reproduce
Activate the hook.
![image](https://github.com/user-attachments/assets/06d0db7d-6141-4905-8642-2441f2b68614)

Commit multiple times locally, changing the app but not in the last commit.
![image](https://github.com/user-attachments/assets/2f68413d-e13e-4698-af6f-39e4af3d93a8)

Push to github.
![image](https://github.com/user-attachments/assets/6589051d-4114-4e10-8d87-2c872de0f12a)

#### Expected behavior
The hook runs, an update is published in the branch channel.

#### Actual behavior
![Screenshot 2024-11-15 at 12 10 54 PM](https://github.com/user-attachments/assets/e86fbb69-6f13-4abc-9e0f-45100b2c5648)

### Additional context
I'm not 100% sure about how to repro but I'll update if I find out more.
If I push a commit that does have changes in the expo folder, the updates hook triggers as expected.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.