expo / expo/expo-github-action

`eas update` and `eas build` created .jsbundle can be different if env vars .eas.json and actions .env vars are different

Open
#302 0 comments 2 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1k
Forks
107
PR merge metrics
No merged PRs in 30d

Description

### Topic and scope of discussion
`continuous-deploy-fingerprint` sometimes call `eas update` if fingerprint matches and `eas build` if it doesn't.
* `eas update` picks environment variable form `env:` set in GitHub actions. [docs](https://docs.expo.dev/guides/environment-variables/#eas-build)
* `eas build` picks environment variables from `eas.json` [docs](https://docs.expo.dev/guides/environment-variables/#eas-build)

This can cause `continuous-deploy-fingerprint` actions to produce different jsbundle for update vs build.

### Motivation
Building different .jsbundle for update vs build can be problematic. And while the expo docs mentions this for `EAS Build` and `EAS Update` this can be suprising for `continuous-deploy-fingerprint` consumers.

### Additional context
https://github.com/mfazekas/env-sample demonstrates the issue

Not sure if this can/should be fixed/warned/documented.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.