expo / expo/examples

Service worker examples incomplete, do not specify the `config` object or `PUBLIC_URL`

Open
#414 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
3.7k
Forks
1.1k
Avg merge
11h 15m
Merged PRs (30d)
1

Description

**Describe the bug**

The documentation for the service worker example implementation does not explain the `config` object, referenced at https://github.com/expo/examples/blob/bd68019bc808479a3ff99d0a6f69374871713b21/with-workbox/src/serviceWorkerRegistration.js#L23

It's kinda-sorta self-explanatory but isn't utilized in the calling code at https://github.com/expo/examples/blob/cfb044b07385773fac2247be968cc5c0b13be8bf/with-workbox/App.js#L23

**To Reproduce**

n/a

**Expected behavior**

The `config` object and the required (?) `PUBLIC_URL` environment variable are documented.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.