expo / expo/eas-cli

Handle missing node_modules better

Open Beginner friendly
#4,213 0 comments 0 reactions 0 assignees View on GitHub
needs review
Dominant language
TypeScript
Stars
1.4k
Forks
236
Avg merge
3d 1h
Merged PRs (30d)
91

Description

### Build/Submit details page URL

_No response_

### Summary

```
~/code/mac-migration (main) v22.14 ❯ eas update:configure
★ eas-cli@21.8.0 is now available.
To upgrade, run:
npm install -g eas-cli
Proceeding with outdated version.

/Users/brent/code/mac-migration/node_modules/expo/bin/cli config --json exited with non-zero code: 1
Error: update:configure command failed.
```

we should detect this situation and provide a useful error message

### Managed or bare?

Irrelevant

### Environment

Irrelevant

### Error output

See above

### Reproducible demo or steps to reproduce from a blank project

- Create a project
- Delete `node_modules`
- Run `eas update:configure`

Contributor guide

Open the contributing guide

Research direction

Reproduce the issue by deleting node_modules and running eas update:configure, then trace the update:configure entry point where expo/bin/cli is invoked. Done means the missing-dependency case is detected and the command reports a useful error instead of only the non-zero exit failure; rerun the command to verify the message.

Written by the indexing model from the issue text.

Assessment

Tech stack
node.js, typescript
Domain
cli
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.