expo / expo/eas-cli

Version Code Commention Issues

Open
#2,986 0 comments 0 reactions 0 assignees View on GitHub
needs review
Dominant language
TypeScript
Stars
1.4k
Forks
236
Avg merge
3d 1h
Merged PRs (30d)
91

Description

### Build/Submit details page URL

https://expo.dev/accounts/apper362/projects/Smartchore/builds/b61a0fc1-f455-44f7-bccc-3bf9ba35e4a2

### Summary

When I create an android build, I specify versionCode 1 // App version code (increment for each release)
versionName "1.0.0" // App version name under my configurations in android/app/build.gradle, but in the eas build page, it shows the versions as: ' "1.0.0" // App version name (1 // App version code (increment for each release))' where it includes the comments. Whichever eas build mechanism extracts the version code needs to ignore comments

### Managed or bare?

managed

### Environment

doesn't matter for this bug

### Error output

-

### Reproducible demo or steps to reproduce from a blank project

Create any expo project, and run expo prebuild, then add versionCode 1 // App version code (increment for each release)
versionName "1.0.0" // App version name in android.defaultConfig in your YourAppName/android/app/build.gradle

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.