expo / expo/code-review-cli

run with all passes failed still reports Approve with comments

Open
#55 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1
Forks
0
Avg merge
1d 21h
Merged PRs (30d)
2

Description

Seen on 0.9.2. A run where every review pass failed (subscription session limit) still prints the verdict "AI code review — Approve with comments":

```
terraform-safety: FAILED (You've hit your session limit · resets 1:50am)
cross-repo-boundary: FAILED (...)
cluster-scaling: FAILED (...)
kubernetes-manifests: FAILED (...)
infra-security: FAILED (...)
All review passes failed — reporting an incomplete review.
Token usage — input 0, output 0, cache read 0, cache write 0

AI code review — Approve with comments
no findings

⚠️ The AI review could not complete: every review pass failed or timed out, so these changes were effectively NOT reviewed.
```

The body does say "treat this as no review", but the headline is still an approve variant. In `ecr ci` that posts a PR comment that reads as a green light unless you read the fine print, and the check stays green. When all passes fail (or coverage drops below some threshold) the verdict should be a distinct failed/incomplete state, not approve, and `ecr ci` should exit non-zero so the CI check goes red.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at the ecr ci entry point and trace how failed review passes are converted into the displayed verdict, pull-request comment, and process exit status. Reproduce the all-passes-failed case described in the issue, then verify that incomplete or below-threshold coverage produces a distinct failed state, a non-zero exit, and a red CI check rather than an approval.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
ci-cd, cli
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.