exoplanet-dev / exoplanet-dev/case-studies

Issue on page /tutorials/tess.html and/or in documentation of get_ror_from_approx_transit_depth

Open
#57 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
3
Forks
14
PR merge metrics
No merged PRs in 30d

Description

This case study has: "r_pl = pm.Deterministic("r_pl", ror * r_star)" for calculating the planetary radius. According to the documentation for get_light_curve, r_pl is in units of solar radii, not the host star radius. However, this example gets ror from get_ror_from_approx_transit_depth, for which the documentation says ror is the radius ratio and is not explicit about units. I suggest clarifying in both the case study tutorial and in the documentation about the units.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.