exercism / exercism/typescript
'Robot Name' false positive tests
- Dominant language
- TypeScript
- Stars
- 165
- Forks
- 173
- PR merge metrics
- No merged PRs in 30d
Description
## Issue
The top-ranked solutions for 'Robot Name' in Typescript are currently passing all unit tests even though (and primarily because) they are generating names that **_do not conform_** to the problem specification.
While the tests interpret these names as 'unique' because they do not exist within their respective Sets, repeating the regex check for each 'new name' function invocation exposes these strings as invalid robot names.
[2nd Solution](https://exercism.org/tracks/typescript/exercises/robot-name/solutions/jcsawyer123)

[3rd Solution](https://exercism.org/tracks/typescript/exercises/robot-name/solutions/mangapi)

## Notes
- This issue may need to be addressed in other tracks as well.
- Implementing the regex check for each newly generated name adds about 10 seconds to even the most optimal solutions when checking all possible permutations. There may be a more performant approach for strengthening these tests.
[<200ms solution](https://exercism.org/tracks/typescript/exercises/robot-name/solutions/bobahop)

## Quick Links
https://github.com/exercism/typescript/blob/main/exercises/practice/robot-name/.docs/instructions.md
https://github.com/exercism/typescript/blob/main/exercises/practice/robot-name/robot-name.test.ts
https://exercism.org/tracks/typescript/exercises/robot-name
Contributor guide
Assessment
This issue has not been assessed yet.