exercism / exercism/javascript-analyzer

Improve resistor-color-duo: handle solutions based on reduce

Open
#57 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
16
Forks
21
Avg merge
6h 53m
Merged PRs (30d)
2

Description

Currently, when a solution contains `reduce`, we _explicitly_ bail out early. The following two examples should be considered _approvable_, but **not** optimal. Both should come with a hint.

```
const value = (colors) => {
return Number(
colors
.slice(0,2)
.reduce((digits, color) => digits + colorCode(color), '')
)
}
```
Use the type-juggling message hint.

```
function value(colors) {
return colors
.slice(0,2)
.reduce((value, color, index) => value + colorCode(color) * Math.pow(10, 1 - index), 0)
}
```
Use a new hint: Is `reduce` really the best candidate when trying to get the sum of significant digit values, when there are _two_ values only.

**Which exercise**

`resistor-color-duo`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.