exercism / exercism/csharp

Bank Account (Unit Tests)

Open
#2,406 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
427
Forks
383
Avg merge
2d 2h
Merged PRs (30d)
5

Description

I am not sure if I am doing ti right, but the tests indicate that the cancellation token should be passed from a given source.

We received the following error when we ran your code:

BankAccountTests.cs(158,23): warning xUnit1051: Calls to methods which accept CancellationToken should use TestContext.Current.CancellationToken to allow test cancellation to be more responsive. (https://xunit.net/xunit.analyzers/rules/xUnit1051)

I am sure the test case with the Tasks is the one with the issue, as indicated by the error message.

`csharp
[Fact(Skip = "Remove this Skip property to run this test")]
public async Task Can_handle_concurrent_transactions()
{
var account = new BankAccount();
account.Open();
for (int i = 0; i < 500; i++)
{
var tasks = new List();
tasks.Add(Task.Factory.StartNew(() =>
{
for (int j = 0; j < 100; j++)
{
account.Deposit(1m);
account.Withdraw(1m);
}
}));
await Task.WhenAll(tasks.ToArray());
}
Assert.Equal(0m, account.Balance);
}
`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.