exceljs / exceljs/exceljs

[BUG] Drawings dropped on saving, 4.4.0

Open
#2,647 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
15.5k
Forks
2k
PR merge metrics
No merged PRs in 30d

Description

## 🐛 Bug Report

I'm getting some of my drawings removed while saving the file.

Lib version: 4.4.0

## Steps To Reproduce

```javascript
const wb = new ExcelJS.Workbook();
const templatePath = 'path to a given template'
const filePath = 'path to file to be saved'
await wb.xlsx.readFile(templatePath);

const sheet = wb.getWorksheet('Sheet1');

await file.xlsx.writeFile(filePath)

This is plain simple, but the template file has the following drawings:
![image](https://github.com/exceljs/exceljs/assets/55882933/975d308a-91a8-40d8-94df-0f95f608c8e0)

But the resulting file has the following drawings, even though it has all the .vml files:
![image](https://github.com/exceljs/exceljs/assets/55882933/fcbe5df7-5e69-42c3-872c-45b29cfd5fd9)

```

## The expected behaviour:

The drawings should stay untouched. Is there a size limit to drawings on a number of drawings limit?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.