exceljs / exceljs/exceljs

Make date1904 property on CellFormulaValue interface optional

Open
#1,033 1 comment 8 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
15.5k
Forks
2k
PR merge metrics
No merged PRs in 30d

Description

`export interface CellFormulaValue {
formula: string;
result?: number | string | Date | { error: CellErrorValue };
date1904: boolean;
}`
Currently that is how it is written. It is forcing you to add a date even though you only need the formula. Maybe make it like:
`export interface CellFormulaValue {
formula: string;
result?: number | string | Date | { error: CellErrorValue };
date1904?: boolean;
}`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.