evollu / evollu/react-native-firebase-analytics

screen_view is reserved, but not in list of reserved names

Open
#55 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
206
Forks
52
PR merge metrics
No merged PRs in 30d

Description

This package includes a list of reserved event names which doesn't include "screen_view". So tracking events manually using `logEvent("screen_view")` will actually fail. I encountered this since `setCurrentScreen(...)` doesn't actually track anything and the automatic tracking doesn't work (likely because RN projects usually don't use native navigation components.

Fix is simply to add 1 line in `lib/modules/analytics/index.js` in the `const ReservedEventNames` array: `'screen_view'`

Thanks

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.