evilsocket / evilsocket/shieldwall

Logo in github dark mode is almost invisible

Open
#6 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Go
Stars
265
Forks
30
PR merge metrics
No merged PRs in 30d

Description

Not a really big issue, but the current logo being used for the readme is not easily visible in github's dark mode.
Currently it looks like this:
![Screenshot 2021-05-21 at 10 13 07 AM](https://user-images.githubusercontent.com/25097841/119083212-25725580-ba1d-11eb-93f0-df7bc117730f.png)

While there has been [discussion](https://github.community/t/support-theme-context-for-images-in-light-vs-dark-mode/147981) for theme context images in GitHub forums, no conclusion seems to have come from it. In the meantime, a white border can be added to the logo to make it more visible (while preserving the same look for the light theme). Something like this:
![Screenshot 2021-05-21 at 10 13 39 AM](https://user-images.githubusercontent.com/25097841/119083251-391dbc00-ba1d-11eb-90b4-1937536ecfaa.png)
The same looks nice (and also identical) for the other two themes too:

![Screenshot 2021-05-21 at 10 14 36 AM](https://user-images.githubusercontent.com/25097841/119083316-5b173e80-ba1d-11eb-8b5d-8814743cc52f.png) ![Screenshot 2021-05-21 at 10 14 57 AM](https://user-images.githubusercontent.com/25097841/119083335-67030080-ba1d-11eb-8bc0-1021b55ce6cd.png)
Same has been implemented by other projects too using a black logo: [fastify](https://github.com/fastify/fastify), [next.js](https://github.com/vercel/next.js/).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.