evanw / evanw/node-source-map-support

Why use Buffer as an implicit dependency?

Open
#95 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
2.2k
Forks
223
PR merge metrics
No merged PRs in 30d

Description

:point_up: :point_right: https://github.com/evanw/node-source-map-support/blob/6296f616ca56fc1e1ced36ea15a2eb43d4227c54/source-map-support.js#L111

**Background:**
We (https://github.com/CartoDB/cartodb) suffered a `Uncaught RangeError: Maximum call stack size exceeded` exception on uncaught exceptions after upgrading browserify. I found some similar reported stuff here, e.g. #86 and #93, but after some investigation I found the culprit to be the implicit dependency of [buffer](https://github.com/feross/buffer) used at the line above.

Since there's no reference to this module in this repo I presume that it's accessible through the [browserify module](https://github.com/substack/node-browserify/blob/11.0.1/package.json#L28)? Considering it's a key piece for this module to work, why not define the dependency in this package?

~~That said, there's [a fix](https://github.com/feross/buffer/commit/c681bda) but it's not yet released (v3.4.2), so my temporary workaround to this was to override the implicit dependency, see: https://github.com/CartoDB/cartodb/pull/5171/files~~ The fix was released in [buffer v3.4.2](https://github.com/feross/buffer/tree/v3.4.3)

cc @tanem who seem to have suffered similar issues, perhaps this also works for you

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.