evanmoran / evanmoran/oj

Support `use strict`: Change with(oj) to oj.extendInto(this)

Open
#20 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
441
Forks
7
PR merge metrics
No merged PRs in 30d

Description

https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Statements/with

Many scripts and libraries use `"use strict";`. In order to not run into complications, OJ probably should extend into the scope that it wants to. In the case of a rendering sequence:

``` javascript
(function(){try{ oj.extendInto(this); (function(){
h1("Foo bar");
}).apply(this);}catch(e){ handle_error(e); }})();
```

Just a thought, since I just read the article.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.