euroargodev / euroargodev/argopy

Refactor accessor QC filter as an extension

Open
#475 1 comment 0 reactions 0 assignees View on GitHub
breaking-change good first issue internals stale
Dominant language
Python
Stars
229
Forks
52
Avg merge
1d 17h
Merged PRs (30d)
5

Description

In line with effort started with data mode processing features that were refactored as an ``argo`` accessor extension in https://argopy.readthedocs.io/en/latest/generated/xarray.Dataset.argo.datamode.html.

Here, we propose to continue refactoring of all the other filters:
https://argopy.readthedocs.io/en/latest/user-guide/working-with-argo-data/data_manipulation.html#filters

and in particular [QC processing] that currently look like this:(https://argopy.readthedocs.io/en/latest/generated/xarray.Dataset.argo.filter_qc.html):
```python
from argopy import DataFetcher
ArgoSet = DataFetcher(mode='expert').float(1902605)
ds = ArgoSet.to_xarray()
ds.argo.filter_qc()
```

it could go under a new extension ``qc``:
```python
from argopy import DataFetcher
ArgoSet = DataFetcher(mode='expert').float(1902605)
ds = ArgoSet.to_xarray()
ds.argo.qc.filter()
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.