euroargodev / euroargodev/argopy

Different size of matrix using create_float_source for raw and adjusted data

Open
#218 11 comments 0 reactions 0 assignees View on GitHub
argo-core argo-deep forQCexpert invalid stale
Dominant language
Python
Stars
229
Forks
52
Avg merge
2d 10h
Merged PRs (30d)
8

Description

I have found a differences in size of the matrix generated by the ds.argo.create_float_source code for generating the Wong matrix .mat for OWC analysis. The differences appear for .mat matrix for raw data and adjusted data.

```
ds.argo.create_float_source(force='raw')
ds.argo.create_float_source(force='adjusted')
```

The equivalent matlab code to generate float source is giving the same size of output for raw and adjusted data https://github.com/euroargodev/dm_floats/blob/master/src/ow_source/create_float_source.m

The WMO float examples where the issue have been detected: 3901928, 3900797,3900799
The mismatch between size of matrices including raw and adjusted data lead to problems in extracting differences and comparing data during checks of the quality of adjusted data.

I am using the argopy v0.1.11 version.

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the issue with ds.argo.create_float_source(force='raw') and force='adjusted' for floats 3901928, 3900797, and 3900799. Compare the resulting matrix dimensions with the MATLAB create_float_source.m implementation linked in the issue. Done means raw and adjusted matrices have matching sizes and can be compared during adjusted-data quality checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.