ethereum / ethereum/trinity-eth2

Replace state transition helper functions with optimized versions.

Open
#18 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
16
Forks
9
PR merge metrics
No merged PRs in 30d

Description

### What is wrong?

In https://github.com/ethereum/trinity/pull/1918, we copied https://github.com/protolambda/eth2fastspec into our repo and made the minimal changes required for compatibility. A major improvement in code quality would be to replace the existing helper functions with their optimized versions.

### How can it be fixed

- [ ] replace existing helper functions with optimized versions
- [x] raise `ValidationErrors` instead of `AssertionErrors` when validation fails ethereum/trinity#1977
- [x] parameterize config values, instead of hardcoding Altona values https://github.com/ethereum/trinity/pull/1967
- [ ] ensure that spec tests are running on optimized helper functions

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.