ethereum / ethereum/trinity-eth2

Add missing spec tests for rewards/penalties logic

Open
#10 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
16
Forks
9
PR merge metrics
No merged PRs in 30d

Description

It looks like we currently do not run the rewards/penalties spec tests during the epoch processing fixtures.

Tests here:
https://github.com/ethereum/eth2.0-spec-tests/tree/v0.12.1/tests/minimal/phase0/epoch_processing/rewards_and_penalties/pyspec_tests

And new tests were added in v0.12.x to more granularly test rewards calculations; tests here:

https://github.com/ethereum/eth2.0-spec-tests/tree/v0.12.1/tests/minimal/phase0/rewards/core/pyspec_tests

We will want to add both to our fixture suite.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.