ethereum / ethereum/tests

Update LegacyTests submodule (fix for pre-Spurious Dragon state roots)

Open
#1,498 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
626
Forks
364
PR merge metrics
No merged PRs in 30d

Description

## Summary

The `LegacyTests` submodule needs to be updated to include the fix from https://github.com/ethereum/legacytests/pull/16.

## Problem

Several tests in `LegacyTests` have incorrect expected state roots for pre-Spurious Dragon forks (Frontier, Homestead, EIP150) when transactions are invalid. This is due to the test generation EVM incorrectly creating an empty COINBASE account.

## Affected Tests (11 files)

- `stExample/eip1559.json`
- `stExample/accessListExample.json`
- `stExample/basefeeExample.json`
- `stTransactionTest/HighGasPrice.json`
- `stTransactionTest/HighGasPriceParis.json`
- `stTransactionTest/ValueOverflow.json`
- `stTransactionTest/ValueOverflowParis.json`
- `stTransactionTest/NoSrcAccount.json`
- `stTransactionTest/NoSrcAccount1559.json`
- `stTransactionTest/NoSrcAccountCreate.json`
- `stTransactionTest/NoSrcAccountCreate1559.json`

## Related Issues

- ethereum/execution-specs#1967
- bluealloy/revm#3270
- ethereum/go-ethereum#33527

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.