ethereum / ethereum/tests

Discrepancy in chainId for BlockchainTests in EIP-6780 Selfdestruct Tests

Open
#1,394 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
626
Forks
364
PR merge metrics
No merged PRs in 30d

Description

I noticed that some of the BlockchainTests tests, mainly the ones under [cancun/eip6780_selfdestruct](https://github.com/ethereum/tests/blob/develop/BlockchainTests/GeneralStateTests/Pyspecs/cancun/eip6780_selfdestruct/create_selfdestruct_same_tx.json#L46), are executed on a state that has the `chainId` set to `0` instead of `1`. Is there a reason they have a different `chainId` than the rest of the test suite?

Alternatively, would you consider storing the `chainId` under the `_info` field of the JSON test? Or add it as a new field on the same level as `sealEngine` and `network`? I know it is already part of the `transaction` field, but I consider that a post-state check, similar to `sender`.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.