ethereum / ethereum/staking-launchpad

Unable to update when a transaction fails and is re-sent

Open
#247 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
304
Forks
226
PR merge metrics
No merged PRs in 30d

Description

I've come across a minor issue. When I first went to deposit my validator, I took too long getting into my hardware wallet and timed out, so the wallet and launchpad marked the transaction as failed. Best practice at this point (in my view) is to retry the same transaction from within my wallet since it handles the nonces and will re-send with the same nonce rather than creating an opportunity to accidentally double up, as client pages sometimes do.

So I did that, but then the launchpad was unable to detect that I had re-sent the transaction, so it just left it marked as failed even after the transaction confirmed. This definitely creates a danger for double-sending via the "try again" button.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.