ethereum / ethereum/pyethsaletool
assumes immediate confirmation from interim address
- Dominant language
- Python
- Stars
- 103
- Forks
- 135
- PR merge metrics
- No merged PRs in 30d
Description
This code assumes that the btc sent to the funding address was confirmed in the immediately preceding block. The intent is to give the customer the benefit of the doubt, and credit them with a rate when they started the process, not when it finally finished.
I have found sequential confirmations was not the case with the factom sale.
It is a bummer that blockchain.info does not give the txid of the inputs being spent. this would make the code fixable.
https://github.com/ethereum/pyethsaletool/blob/master/genesis_block_generator.py#L92
factom is using multiple methods to create and validate the genesis block, which should highlight outliers like this.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.