ethereum / ethereum/pyethsaletool

script does not recognize duplicate addresses (187 missing BTC)

Open
#2 8 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
103
Forks
135
PR merge metrics
No merged PRs in 30d

Description

I am modifying this script to create the factom genesis block. I found it does not recognize duplicate funding to the same address.

If someone sends in BTC twice to the same ether address, only the last one\* will be credited by the script.

https://github.com/ethereum/pyethsaletool/blob/master/genesis_block_generator.py#L120

*not necessarily last one in time, because bc.i and json mix things up.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.