ethereum / ethereum/py-solc

py-solc is incompatible with Solidity compiler 0.5.0

Open
#64 5 comments 5 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
195
Forks
77
PR merge metrics
No merged PRs in 30d

Description

* `py-solc` Version: 3.2.0
* `solc` Version: 0.5.0
* Python Version: 3.6.7
* OS: Linux

### What was wrong?
py-solc is incompatible with Solidity compiler 0.5.0

`--combined-json clone-bin` is deprecated in version 0.5.0 but is set in main.py and wrapper.py. Has to be removed.

Compile from source uses the solc compiler option to compile from stdin but does this incorrectly.
The fix would be to add `command += "-" ` at the end of the command creation.
A quick and dirty fix for both issues can be seen on my repository master branch at:

https://github.com/Jonasmpi/py-solc

#### Cute Animal Picture

![](https://i.imgur.com/1eCK2AH.jpg)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.