ethereum / ethereum/populus

Update json schema to accept "fallback" type functions

Open
#328 5 comments 0 reactions 0 assignees View on GitHub
Good First Issue
Dominant language
No language data
Stars
319
Forks
110
PR merge metrics
No merged PRs in 30d

Description

* Populus Version: 1.8.0
* OS: osx/linux/win

### What was wrong?

Solidity now includes an ABI entry for the *fallback* function which is not valid under the current json-schema used to validate contract data.

### How can it be fixed?

Update the json-schema here: https://github.com/pipermerriam/populus/blob/3a0445e550baa344a0931a2b94f3c779c98505fe/populus/assets/contract-data.v1.schema.json#L48-L50

A new option should be added for a `FallbackFunctionABI` which allows for `{"type": "fallback"}`.

#### Cute Animal Picture

> put a cute animal picture here.

![baby-honey-badger](https://user-images.githubusercontent.com/824194/28984189-f3af0b08-7919-11e7-9b84-cd9550cba7c3.jpg)

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with populus/assets/contract-data.v1.schema.json around lines 48–50, as linked in the issue, and compare the current ABI type options with Solidity's fallback ABI entry. Update the schema to accept {"type":"fallback"}, then validate contract data containing a fallback function against the schema.

Written by the indexing model from the issue text.

Assessment

Tech stack
json, solidity
Domain
blockchain, tooling
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.