ethereum / ethereum/populus

Extra keys in `$ref` values within configuration should throw an error.

Open
#283 1 comment 0 reactions 0 assignees View on GitHub
Good First Issue
Dominant language
No language data
Stars
319
Forks
110
PR merge metrics
No merged PRs in 30d

Description

* Populus Version: 1.6.x
* OS: all

### What was wrong?

Any *reference* in a configuration file which has *extra* keys should throw an error at the time the configuration file is loaded and validated.

Example: https://gist.github.com/poiresel/0cf1aba442be17fead55c00fb2d3c546#file-populus-json-L110-L115

#### Cute Animal Picture

![2542595839_b138b55cbe](https://cloud.githubusercontent.com/assets/824194/25247739/05c45c98-25c9-11e7-987b-893619cc82ea.jpeg)

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the configuration loading and validation entry point, using the linked gist as the reproduction case for a reference containing extra keys. Trace how that configuration is checked and add coverage showing that loading such a file reports an error; done means the invalid reference is rejected during validation.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.