ethereum / ethereum/execution-specs

Enable more of mypy's diagnostics

Open
#983 2 comments 0 reactions 0 assignees View on GitHub
A-spec-tools C-feat E-easy P-high stale
Dominant language
Python
Stars
1.2k
Forks
505
Avg merge
2d 14h
Merged PRs (30d)
116

Description

The full list is here: https://mypy.readthedocs.io/en/stable/error_code_list2.html

From a quick read, we probably want to enable at least:

- `disallow-any-generics`
- `disallow-untyped-defs`
- `warn-redundant-casts`
- `strict-equality`
- `disallow-untyped-calls`
- `warn-return-any`
- `disallow-any-unimported`
- `warn-unreachable`
- `ignore-without-code`
- `unused-ignore`
- `explicit-override`
- `mutable-override`

I think some of these are already on, but it doesn't hurt to check.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.