ethereum / ethereum/execution-specs
`test_memory_*` benchmark refactor
- Dominant language
- Python
- Stars
- 1.2k
- Forks
- 505
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 116
Description
The high depth variants in `test_memory` run out of gas mid descent and revert unnoticed, so the benchmark never actually reaches the advertised depth.
Fixed here if you want it: https://github.com/spencer-tb/execution-specs/commit/b07128d21cd1c2f8b5c33ff677c6bcd921228020, feel free to cherry-pick.
_Originally posted by @spencer-tb in https://github.com/ethereum/execution-specs/pull/3349#pullrequestreview-5077039726_
Contributor guide
Research direction
Start by locating the test_memory_* benchmark variants and compare their gas/revert handling with commit b07128d21cd1c2f8b5c33ff677c6bcd921228020. Run the relevant memory benchmarks and confirm that high-depth variants do not silently revert before reaching their advertised depth.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- performance, testing-qa
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 74/100