ethereum / ethereum/execution-specs

Resolve implicit gas limits in transaction tests

Open
#3,489 0 comments 0 reactions 1 assignee Claimed by @danceratopz View on GitHub
A-test-fixtures C-feat
Dominant language
Python
Stars
1.2k
Forks
505
Avg merge
2d 14h
Merged PRs (30d)
116

Description

## Problem

State and blockchain test fillers resolve an omitted transaction gas limit before signing. `TransactionTest` does not. As a result, transaction tests must provide an otherwise arbitrary gas limit or signing fails with `gas_limit must be set to sign a transaction`.

## Proposed change

Resolve omitted gas limits in `TransactionTest` before signing, using the shared implicit gas-limit behavior and a documented transaction-test gas budget. Keep explicit gas limits unchanged for boundary and invalid-transaction tests.

Add coverage for omitted and explicit limits, then remove redundant gas limits from transaction-test unit tests. Verify and document any fixture changes.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.