ethereum / ethereum/execution-specs
Backport fork-generic tests from projects/binary-trie to forks/amsterdam
- Dominant language
- Python
- Stars
- 1.2k
- Forks
- 505
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 116
Description
Per https://github.com/ethereum/execution-specs/pull/3338#issuecomment-5226985384: several tests under `tests/binary_tree/eip8297_partitioned_binary_tree/` assert fork-generic semantics but are pinned `valid_from("BinaryTree")`, so no other fork runs them. Move each to its EIP's directory on `forks/amsterdam` with the earliest applicable `valid_from`.
Candidates: the three 4788 tests in `test_system_contracts.py` (→ cancun/eip4788); `test_same_target_reauthorization_keeps_designator` (→ prague/eip7702); `test_create2_recreate_with_different_code` (→ cancun/eip6780); the generic arms of `test_account_lifecycle.py`, `test_storage_ops.py`, `test_tx_types.py`, `test_multi_block.py`.
Contributor guide
Research direction
Start in tests/binary_tree/eip8297_partitioned_binary_tree/ and review the candidates in test_system_contracts.py, test_account_lifecycle.py, test_storage_ops.py, test_tx_types.py, and test_multi_block.py. Move the specified fork-generic tests into the applicable forks/amsterdam EIP directories, using the earliest applicable valid_from; confirm each test runs for its intended fork.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100