ethereum / ethereum/execution-specs

`consume direct`: xfail geth for 7610

Open
#2,957 1 comment 0 reactions 0 assignees View on GitHub
C-test P-low stale
Dominant language
Python
Stars
1.2k
Forks
505
Avg merge
2d 14h
Merged PRs (30d)
116

Description

if you fill

`uv run fill -v -s --no-html --clean ./tests/paris/eip7610_create_collision/test_revert_in_create.py -k test_collision_with_create2_revert_in_initcode`

and then consume with:

`uv run consume direct -v -s --bin=/home/user/Documents/erigon/build/bin/evm`

erigon (any other clients) pass all tests, but if you run it against `geth` you get 10 failures. that is because geth hardcodes the few relevant cases that exist for `eip-7610` (so it is not an actual problem, their approach is valid and correct). i don't think we can easily fix this test, and our framework does not have the feature where you can specify expected fails (xfail) on a client-to-client granularity. this issue is about the question whether we want such a feature, or whether we can rework this test in some other way that makes all clients happy.

also the fact that we do not catch these failures in an automated way supports the argument that we should give more love to `consume direct` and maybe even include it in CI in some form. i tripped over this when fuzzing btw

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.