ethereum / ethereum/execution-specs
Don't pass `--opcode.count` to geth's `t8n` when filling non-benchmark tests
Open
A-test-client-clis
A-test-fill
C-chore
stale
- Dominant language
- Python
- Stars
- 1.2k
- Forks
- 505
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 116
Description
Low prio, but there'd be two reasons for not doing this:
1. We blow-up fixture JSON file sizes with unused opcode counts for consensus tests. Open to the possibility that they could be useful though.
2. Lower prio: We can no longer fill with geth versions that pre-date this flag.
Contributor guide
Assessment
This issue has not been assessed yet.