ethereum / ethereum/execution-specs

Investigate and potentially eliminate all remaining consensus test skips

Open
#2,554 2 comments 0 reactions 0 assignees View on GitHub
A-tests C-chore stale
Dominant language
Python
Stars
1.2k
Forks
505
Avg merge
2d 14h
Merged PRs (30d)
116

Description

These PRs brought the number of skips for all tests filled for `--fork=Amsterdam` from 68 to 20 skipped:
- https://github.com/ethereum/execution-specs/pull/2542
- https://github.com/ethereum/execution-specs/pull/2543

These are the remaining skips as of 21407ec427951844f33d1584d10fb123731f6b36:

```
=================== short test summary info ===================
SKIPPED [6] tests/istanbul/eip152_blake2/test_blake2.py:683: Times-out during fill
SKIPPED [6] tests/byzantium/eip198_modexp_precompile/test_modexp.py:29: EELS bug: U256 overflow in modexp pointer arithmetic before Osaka - see github.com/ethereum/execution-specs/issues/1465
SKIPPED [3] tests/prague/eip2537_bls_12_381_precompiles/test_bls12_map_fp2_to_g2.py:98: got empty parameter set for (input_data, vector_gas_value)
SKIPPED [3] tests/prague/eip7702_set_code_tx/test_set_code_txs.py:2563: Cannot use correct_chain_id-1 as invalid chain ID
SKIPPED [2] tests/prague/eip2935_historical_block_hashes_from_state/test_block_hashes.py:227: Slow test not relevant anymore
=================== 72204 passed, 20 skipped in 1031.65s (0:17:11) ===================
```

This can be further cleaned up:
- [ ] `tests/istanbul/eip152_blake2/test_blake2.py:683`: verify and potentially change from skip to `xfail(`run=False,...`. Find an alternative solution to generating these tests.
- [ ] `tests/byzantium/eip198_modexp_precompile/test_modexp.py:29`: change from skip `xfail(run=True,...`. If this only effects forks < Osaka, these should be enabled for newer forks!
- [ ] `tests/prague/eip2537_bls_12_381_precompiles/test_bls12_map_fp2_to_g2.py:98`: todo; investigate clean-up
- [ ] `tests/prague/eip7702_set_code_tx/test_set_code_txs.py:2563`: Can we get the chainid fixture value and remove this test case during parametrization if chainid is 1? This is a valid test for L2s/other chains.
- [ ] `tests/prague/eip2935_historical_block_hashes_from_state/test_block_hashes.py:227`: Delete or perhaps remove test_ prefix to avoid collection.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.