ethereum / ethereum/execution-specs

re-factor `check_transaction`

Open
#2,522 1 comment 0 reactions 1 assignee Claimed by @gurukamath View on GitHub
A-spec-specs C-refactor E-medium stale
Dominant language
Python
Stars
1.2k
Forks
505
Avg merge
2d 14h
Merged PRs (30d)
116

Description

Perhaps this function should eventually be

```
def check_transaction(
block_env: vm.BlockEnvironment,
block_output: vm.BlockOutput,
tx: Transaction,
tx_state: TransactionState,
) -> vm.TransactionEnvironment:
```

i.e build the transaction environment gets built here. What do you think? In any case, I'd like to reserve this change to a later re-factoring PR.

_Originally posted by @gurukamath in https://github.com/ethereum/execution-specs/pull/2175#discussion_r2924084775_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.