ethereum / ethereum/execution-specs

Question on `set_environment` in blockchain.py

Open
#2,262 1 comment 0 reactions 0 assignees View on GitHub
A-test-execution C-question stale
Dominant language
Python
Stars
1.2k
Forks
505
Avg merge
2d 14h
Merged PRs (30d)
116

Description

## Observation

In `set_environment`, we guard bal related logic with `requests_hash`. See [here](https://github.com/ethereum/execution-specs/blob/eb72019d6f55a5e3b1901ab17a503397e7c5b17b/packages/testing/src/execution_testing/specs/blockchain.py#L332)

## Question

Should we be using `bal_hash` instead?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.