ethereum / ethereum/execution-specs
Enable GethTransitionTool tests in tests_pytest_py3 in CI
- Dominant language
- Python
- Stars
- 1.2k
- Forks
- 505
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 106
Description
## Problem
- CI downloads geth v1.10.8 for ethash DAG tests (`geth makedag`).
- The `makedag` subcommand was removed in [v1.12.0](https://github.com/ethereum/go-ethereum/releases/tag/v1.12.0).
- `GethTransitionTool` tests require the `evm` binary from modern geth (1.12+).
- Currently, `evm` is not available in CI, so `GethTransitionTool` tests are skipped.
More context: https://github.com/ethereum/execution-specs/pull/2014#issuecomment-3749052858
## Options
1. **Download two geth versions**: Keep v1.10.8 for `geth`, download modern `geth-alltools` for `evm`.
2. **Build `evm` from source**: Use existing `.github/actions/build-evm-client/geth` action.
3. **Split workflows**: Sandbox environments to avoid conflicts between geth versions.
## Related
- #2014: Added receipt fix for modern geth compatibility.
Contributor guide
Assessment
This issue has not been assessed yet.