ethereum / ethereum/execution-specs

Don't format generated code from `gentest` and `eest make test` if `ruff` is not present

Open
#1,715 2 comments 0 reactions 1 assignee Claimed by @danceratopz View on GitHub
A-test-gentest A-test-make C-feat E-easy stale
Dominant language
Python
Stars
1.2k
Forks
505
Avg merge
2d 14h
Merged PRs (30d)
116

Description

For developers, who have cloned `ethereum/execution-specs`, generated code should be formatted by `ruff` using the settings from `pyproject.toml`. Then's it ready to check-in and passes checks.

However, for package users, to avoid adding `ruff` as a dependency package, it seems fine to simply skip this step, especially since this means we can skip adding `ruff` as a package dependency.

As part of this work, we should remove the addition of the `lint` dependency group from `tests_pytest_pypy3` tox env:
https://github.com/ethereum/execution-specs/blob/38c72986cb7b67fa41ea38d393cc241b25206e5c/tox.ini#L32-L34

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.