ethereum / ethereum/execution-specs

Explore creating `packages/testing-types`

Open
#1,679 1 comment 1 reaction 0 assignees View on GitHub
A-test-types C-refactor E-medium S-needs-discussion stale
Dominant language
Python
Stars
1.2k
Forks
505
Avg merge
2d 14h
Merged PRs (30d)
116

Description

There's a potential benefit of extracting types used in both `packages/testing` and `src/ethereum_spec_tools` and condense them in a dedicated package that can be imported by both, primarily to try to minimize the JSON serialization round-trip performed in each state transition request from the tests to the T8N.

Particularly types contained in `packages/testing/src/execution_testing/client_clis/cli_types.py` have the most potential to be reused.

Creating this tracking issue to discuss potential downsides to this and any walls that could be hit during the process.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.