ethereum / ethereum/execution-specs

Ensure `uv run eest make test` calls `ruff` and formats the generated test module correctly

Open
#1,675 4 comments 0 reactions 1 assignee Claimed by @bodier123 View on GitHub
A-test-make C-bug E-easy stale
Dominant language
Python
Stars
1.2k
Forks
505
Avg merge
2d 14h
Merged PRs (30d)
116

Description

`uv run eest make test` runs correctly, but the generated test module is not correctly formatted.

From the copilot review:

The code now references `AppConfig().ROOT_DIR.parent` instead of `AppConfig().ROOT_DIR` to find pyproject.toml. This change suggests the ROOT_DIR definition may have changed during the refactor. Verify that ROOT_DIR still points to the correct location (packages/testing/src/execution_testing) and document why .parent is now needed.
```suggestion
# Call ruff to format the file
# AppConfig().ROOT_DIR points to 'packages/testing/src/execution_testing'.
# The project's pyproject.toml is located in the parent directory: 'packages/testing/src'.
# Therefore, we use .parent to correctly reference the config file.
```

_Originally posted by @Copilot in https://github.com/ethereum/execution-specs/pull/1654#discussion_r2459545228_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.