ethereum / ethereum/execution-specs

chore(forks): add gas definitions for forks prior to berlin

Open
#1,584 1 comment 1 reaction 0 assignees View on GitHub
A-test-forks A-test-tests C-chore P-low stale
Dominant language
Python
Stars
1.2k
Forks
505
Avg merge
2d 17h
Merged PRs (30d)
117

Description

## Description

Following: https://github.com/ethereum/execution-spec-tests/pull/1952#discussion_r2237634275

> I'm taking a look at our framework and this seems like an issue with the lack of gas definitions for forks prior to Berlin.
In order to not increase the scope of this PR, I would simply constrain the test to only be filled for forks Berlin and after.

Relavent tests to update after adding the fix:
- https://github.com/ethereum/execution-spec-tests/pull/1952/files#diff-f32c31e19610d5b7c0badfa59eeb8a8c7d5fdf09bb3e804265bcba5625678a59R16-R18
- https://github.com/ethereum/execution-spec-tests/pull/2057/files#diff-f32c31e19610d5b7c0badfa59eeb8a8c7d5fdf09bb3e804265bcba5625678a59R152-R153

Contributor guide

Open the contributing guide

Research direction

Start with the discussion in execution-spec-tests PR #1952 and inspect the referenced test changes in PRs #1952 and #2057. Locate the framework's gas definitions, add definitions for forks before Berlin, and update the referenced tests so they cover the newly supported forks.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.