ethereum / ethereum/execution-specs

Improve ported-from update detection in the coverage script

Open
#1,581 1 comment 0 reactions 1 assignee Claimed by @spencer-tb View on GitHub
A-ci C-feat stale
Dominant language
Python
Stars
1.2k
Forks
505
Avg merge
2d 14h
Merged PRs (30d)
116

Description

I feel we could use the [.github/scripts/fill_prepatched_tests.sh](https://github.com/ethereum/execution-spec-tests/blob/main/.github/scripts/fill_prepatched_tests.sh#L19-L22) trick where we checkout the main branch, do ` uv run fill $CHANGED_TEST_FILES --show-ported-from --clean --quiet --links-as-filled --skip-coverage-missed-reason --ported-from-output-file ported_from_files.txt` both in `main` and the branch with the changes, diff the two `ported_from_files.txt` files, and only consider new ported tests the ones that only appear in the new branch.

_Originally posted by @marioevz in https://github.com/ethereum/execution-spec-tests/pull/2013#discussion_r2268027391_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.