ethereum / ethereum/execution-specs

chore(tests): Port all `stTimeConsuming` to benchmark tests folder

Open
#1,572 1 comment 0 reactions 0 assignees View on GitHub
A-test-benchmark C-chore stale
Dominant language
Python
Stars
1.2k
Forks
505
Avg merge
2d 14h
Merged PRs (30d)
116

Description

These tests make no sense anymore since they try to, indiscriminately, use an arbitrarily high gas limit which we cannot adapt in any way when we fill them.

Porting these tests to benchmark tests is the way to go.

Here's the link to the commit which still contains the full set of tests before they are removed: https://github.com/ethereum/execution-spec-tests/tree/5515a70106341a37dd8611dde85f6f5f5e83eede/tests/static/state_tests/stTimeConsuming

I see a point of removing them early in order to be able to fill static tests for Osaka (these are all incompatible with the new ~16M gas limit of the transaction introduced in that fork).

cc @chfast

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.