ethereum / ethereum/execution-specs

refactor(pytest): make `spec_version_checker` plugin independent of the `filler` plugin

Open
#1,546 1 comment 0 reactions 0 assignees View on GitHub
A-test-cli C-refactor P-low stale
Dominant language
Python
Stars
1.2k
Forks
505
Avg merge
2d 14h
Merged PRs (30d)
116

Description

Currently, the `spec_version_checker` collects every "normal" python test case and then detects all the test nodes that contain "eip" in their name. For these tests, a new test `eip_version_check` test is dynamically added for every test module.

As the `spec_version_checker` collects the "normal" tests, it must be be able to execute all the fixtures that they use (from `fill`), which isn't so bad, it's just a bit noisy/ugly. It'd be cleaner to simply collect the python test modules and then generate a test for each module, instead of depending on full regular test case collection.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.