ethereum / ethereum/execution-specs

Add more coverage/parametrizations to `with_all_call_opcodes` and `with_all_precompiles`

Open
#1,536 2 comments 0 reactions 0 assignees View on GitHub
stale
Dominant language
Python
Stars
1.2k
Forks
505
Avg merge
2d 14h
Merged PRs (30d)
116

Description

The `with_all_call_opcodes` marker should also include a parametrization using a sentinel value to signal that the scenario where the `tx.to` is used (as opposed to a `CALL`, `EXTCALL`, etc, from another contract) should be tested.

If for some reason, the test cannot be adapted, the selector can be used to skip this parameter, but a valid reason to do so must be provided.

Also `with_all_precompiles` marker should be extended to allow adding new arguments:
- `precompile_data`: Must contain a valid input to the precompile.
- `precompile_gas` Must contain the gas that is required to successfully execute the precompile with the given data.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.