ethereum / ethereum/execution-specs

feat(consume): improve hive simulator cli ux

Open
#1,528 2 comments 0 reactions 0 assignees View on GitHub
A-test-consume C-feat P-medium stale
Dominant language
Python
Stars
1.2k
Forks
505
Avg merge
2d 14h
Merged PRs (30d)
116

Description

Currently, you "should" specify two values when building an eest simulator image:
1. `branch`
2. `fixtures`
to ensure compatibility and `branch=` is required to avoid turbulence on `main`.

E.g.,
```
./hive -client reth --sim "ethereum/eest" --sim.buildarg fixtures=https://github.com/ethereum/execution-spec-tests/releases/download/v4.1.0/fixtures_develop.tar.gz --sim.buildarg branch=v4.1.0 -sim.timelimit 1s
```

While it's nice to have this flexibility and we should keep it, regular users should just be able to specify:

```
./hive -client reth --sim "ethereum/eest" --sim.buildarg version=v4.1.0
```

which would avoid confusion and potentially mis-matching EEST library and release versions (which is expected to happen, when the pydantic models used to define EEST test vectors get updated with backwards incompatible fields). I would use `fixtures_develop` by default.

Such an interface would probably avoided the issues recently experienced in reth's ci, cf
- https://github.com/paradigmxyz/reth/pull/15274

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.