ethereum / ethereum/execution-specs

refactor Transaction.error field to expected_error

Open
#1,492 2 comments 0 reactions 0 assignees View on GitHub
P-low stale
Dominant language
Python
Stars
1.2k
Forks
505
Avg merge
2d 14h
Merged PRs (30d)
116

Description

in Transactoin class this field

error: List[TransactionException] | TransactionException | None = Field(None, exclude=True)

seems to be "expected_error " the error that we define in tests. need refactor.

I see transaction exception verification. And it looks like tx.error is the error we define ourselves in .py files.

But the actual error reported by the tool is also called error and its confusing

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.